Spoken Language Color Not Showing

Posted by Whisperedecho on Tue 20 May 2008 06:42 AM — 17 posts, 64,051 views.

Whisperedecho USA Tue 20 May 2008 06:42 AM #0

Cross-posted: http://www.smaugmuds.org/index.php?a=topic&t=3715&p=15266#p15266

Hi. Sorry to bother you with another question but I cannot seem to get this problem fixed. I added some color codes into my score dialog. However, now the language that you are speaking does not show up as red anymore. All the languages are just the default color.

Here is the code:


send_to_pager( "&CLanguages&D: ", ch );
   for( iLang = 0; lang_array[iLang] != LANG_UNKNOWN; iLang++ )
      if( knows_language( ch, lang_array[iLang], ch ) || ( IS_NPC( ch ) && ch->speaks == 0 ) )
      {
         if( lang_array[iLang] & ch->speaking || ( IS_NPC( ch ) && !ch->speaking ) )
            set_pager_color( AT_RED, ch );
         send_to_pager( lang_names[iLang], ch );
         send_to_pager( " ", ch );
         set_pager_color( AT_SCORE, ch );
      }
   send_to_pager( "\r\n", ch );

You can see at the top that I added a custom color of light blue to the "Languages" text but the languages that follow are all grey instead of the spoken ones being red.

Is there a way to fix this? The only way I've found so far is to remove all color codes and then the spoken languages show up in red again.

Nick Gammon Australia Forum Administrator Tue 20 May 2008 10:12 PM #1

Well the first thing I notice when investigating this is that stock SmaugFUSS 1.9 does not work properly. With an unmodified version 1.9, I log into admin and try this:


<24hp 145m 110mv> <#1200> 
speak elvish
You now speak elvish.

<24hp 145m 110mv> <#1200> 
config +pager
Ok.

<24hp 145m 110mv> <#1200> 
score

Score for Admin the Attendant.
----------------------------------------------------------------------------
LEVEL: 65          Race : Elf               Played: 58 hours
YEARS: 17          Class: Druid             Log In: Wed May 21 07:31:12 2008
STR  : 10(10)    HitRoll: 1                 Saved:  no save this session
INT  : 15(14)    DamRoll: 0                 Time:   Wed May 21 08:09:38 2008
WIS  : 17(16)      Armor: 0080, improper for adventure
DEX  : 16(16)      Align: +0000, neutral          Items: 00000   (max 13000)
CON  : 12(11)      Pos'n: standing               Weight: 00001 (max 1000000)
CHA  : 16(16)      Wimpy: 0          Style: standard  
LCK  : 12(12) 
Glory: 0000(0000) 
PRACT: 004         Hitpoints: 24    of    24   Pager: (X)  99    AutoExit(X)
XP   : 2000             Mana: 145   of   145   MKills:  00000    AutoLoot( )
GOLD : 10,000           Move: 110   of   110   Mdeaths: 00000    AutoSac ( )
You feel fine.
Languages: common elvish dwarven pixie ogre orcish trollese rodent insectoid
 mammal reptile dragon spiritual magical goblin god ancient halfling clan gith
 gnome 
----------------------------------------------------------------------------
IMMORTAL DATA:  Wizinvis [ ]  Wizlevel (65)
Bamfin:  Admin appears in a swirling mist.
Bamfout: Admin leaves in a swirling mist.

So far, so good, but let's turn the pager off:


<24hp 145m 110mv> <#1200> 
config -pager
Ok.

<24hp 145m 110mv> <#1200> 
score

Score for Admin the Attendant.
----------------------------------------------------------------------------
LEVEL: 65          Race : Elf               Played: 58 hours
YEARS: 17          Class: Druid             Log In: Wed May 21 07:31:12 2008
STR  : 10(10)    HitRoll: 1                 Saved:  no save this session
INT  : 15(14)    DamRoll: 0                 Time:   Wed May 21 08:11:59 2008
WIS  : 17(16)      Armor: 0080, improper for adventure
DEX  : 16(16)      Align: +0000, neutral          Items: 00000   (max 13000)
CON  : 12(11)      Pos'n: standing               Weight: 00001 (max 1000000)
CHA  : 16(16)      Wimpy: 0          Style: standard  
LCK  : 12(12) 
Glory: 0000(0000) 
PRACT: 004         Hitpoints: 24    of    24   Pager: ( )  99    AutoExit(X)
XP   : 2000             Mana: 145   of   145   MKills:  00000    AutoLoot( )
GOLD : 10,000           Move: 110   of   110   Mdeaths: 00000    AutoSac ( )
You feel fine.
Languages: common elvish dwarven pixie ogre orcish trollese rodent insectoid
 mammal reptile dragon spiritual magical goblin god ancient halfling clan gith
 gnome 
----------------------------------------------------------------------------
IMMORTAL DATA:  Wizinvis [ ]  Wizlevel (65)
Bamfin:  Admin appears in a swirling mist.
Bamfout: Admin leaves in a swirling mist.

Hmm - the word "elvish" is no longer red. But it is going through the same code, right? Continued in next post ...

Whisperedecho USA Tue 20 May 2008 10:14 PM #2

Ahhhh!!!

I had turned my pager off because I find it annoying. Let me try turning it back on and see what happens.

Whisperedecho USA Tue 20 May 2008 10:16 PM #3

Yep, now it works as long as you have the pager turned on. If you have it turned off, it doesn't work.

Is there any way to fix it so it shows even if you have the pager turned off?

Nick Gammon Australia Forum Administrator Tue 20 May 2008 10:16 PM #4

For the second, incorrect, attempt I turned on "debug packets" and see this:


Sent  packet: 25 (7 bytes)

score..            73 63 6f 72 65 0d 0a

Incoming packet: 40 (161 bytes)

.[1;36m.[1;36m.[   1b 5b 31 3b 33 36 6d 1b 5b 31 3b 33 36 6d 1b 5b
1;31m.[1;36m.[1;   31 3b 33 31 6d 1b 5b 31 3b 33 36 6d 1b 5b 31 3b
36m.[1;36m.[1;36   33 36 6d 1b 5b 31 3b 33 36 6d 1b 5b 31 3b 33 36
m.[1;36m.[1;36m.   6d 1b 5b 31 3b 33 36 6d 1b 5b 31 3b 33 36 6d 1b
[1;36m.[1;36m.[1   5b 31 3b 33 36 6d 1b 5b 31 3b 33 36 6d 1b 5b 31
;36m.[1;36m.[1;3   3b 33 36 6d 1b 5b 31 3b 33 36 6d 1b 5b 31 3b 33
6m.[1;36m.[1;36m   36 6d 1b 5b 31 3b 33 36 6d 1b 5b 31 3b 33 36 6d
.[1;36m.[1;36m.[   1b 5b 31 3b 33 36 6d 1b 5b 31 3b 33 36 6d 1b 5b
1;36m.[1;36m.[1;   31 3b 33 36 6d 1b 5b 31 3b 33 36 6d 1b 5b 31 3b
36m.[1;36m.[1;36   33 36 6d 1b 5b 31 3b 33 36 6d 1b 5b 31 3b 33 36
m                  6d

Incoming packet: 41 (1024 bytes)

..Score for Admi   0d 0a 53 63 6f 72 65 20 66 6f 72 20 41 64 6d 69
n the Attendant.   6e 20 74 68 65 20 41 74 74 65 6e 64 61 6e 74 2e
..--------------   0d 0a 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d
----------------   2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d
----------------   2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d
----------------   2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d
--------------..   2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 0d 0a
LEVEL: 65          4c 45 56 45 4c 3a 20 36 35 20 20 20 20 20 20 20
   Race : Elf      20 20 20 52 61 63 65 20 3a 20 45 6c 66 20 20 20
            Play   20 20 20 20 20 20 20 20 20 20 20 20 50 6c 61 79
ed: 58 hours..YE   65 64 3a 20 35 38 20 68 6f 75 72 73 0d 0a 59 45
ARS: 17            41 52 53 3a 20 31 37 20 20 20 20 20 20 20 20 20
 Class: Druid      20 43 6c 61 73 73 3a 20 44 72 75 69 64 20 20 20
          Log In   20 20 20 20 20 20 20 20 20 20 4c 6f 67 20 49 6e
: Wed May 21 07:   3a 20 57 65 64 20 4d 61 79 20 32 31 20 30 37 3a
31:12 2008..STR    33 31 3a 31 32 20 32 30 30 38 0a 0d 53 54 52 20
 : 10(10)    Hit   20 3a 20 31 30 28 31 30 29 20 20 20 20 48 69 74
Roll: 1            52 6f 6c 6c 3a 20 31 20 20 20 20 20 20 20 20 20
        Saved:     20 20 20 20 20 20 20 20 53 61 76 65 64 3a 20 20
no save this ses   6e 6f 20 73 61 76 65 20 74 68 69 73 20 73 65 73
sion..INT  : 15(   73 69 6f 6e 0a 0d 49 4e 54 20 20 3a 20 31 35 28
14)    DamRoll:    31 34 29 20 20 20 20 44 61 6d 52 6f 6c 6c 3a 20
0                  30 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20
  Time:   Wed Ma   20 20 54 69 6d 65 3a 20 20 20 57 65 64 20 4d 61
y 21 08:14:57 20   79 20 32 31 20 30 38 3a 31 34 3a 35 37 20 32 30
08..WIS  : 17(16   30 38 0a 0d 57 49 53 20 20 3a 20 31 37 28 31 36
)      Armor: 00   29 20 20 20 20 20 20 41 72 6d 6f 72 3a 20 30 30
80, improper for   38 30 2c 20 69 6d 70 72 6f 70 65 72 20 66 6f 72
 adventure..DEX    20 61 64 76 65 6e 74 75 72 65 0d 0a 44 45 58 20
 : 16(16)      A   20 3a 20 31 36 28 31 36 29 20 20 20 20 20 20 41
lign: +0000, neu   6c 69 67 6e 3a 20 2b 30 30 30 30 2c 20 6e 65 75
tral          It   74 72 61 6c 20 20 20 20 20 20 20 20 20 20 49 74
ems: 00000   (ma   65 6d 73 3a 20 30 30 30 30 30 20 20 20 28 6d 61
x 13000)..CON  :   78 20 31 33 30 30 30 29 0d 0a 43 4f 4e 20 20 3a
 12(11)      Pos   20 31 32 28 31 31 29 20 20 20 20 20 20 50 6f 73
'n: standing       27 6e 3a 20 73 74 61 6e 64 69 6e 67 20 20 20 20
           Weigh   20 20 20 20 20 20 20 20 20 20 20 57 65 69 67 68
t: 00001 (max 10   74 3a 20 30 30 30 30 31 20 28 6d 61 78 20 31 30
00000)..CHA  : 1   30 30 30 30 30 29 0d 0a 43 48 41 20 20 3a 20 31
6(16)      Wimpy   36 28 31 36 29 20 20 20 20 20 20 57 69 6d 70 79
: 0          Sty   3a 20 30 20 20 20 20 20 20 20 20 20 20 53 74 79
le: standard  ..   6c 65 3a 20 73 74 61 6e 64 61 72 64 20 20 0d 0a
LCK  : 12(12) ..   4c 43 4b 20 20 3a 20 31 32 28 31 32 29 20 0d 0a
Glory: 0000(0000   47 6c 6f 72 79 3a 20 30 30 30 30 28 30 30 30 30
) ..PRACT: 004     29 20 0d 0a 50 52 41 43 54 3a 20 30 30 34 20 20
       Hitpoints   20 20 20 20 20 20 20 48 69 74 70 6f 69 6e 74 73
: 24    of    24   3a 20 32 34 20 20 20 20 6f 66 20 20 20 20 32 34
   Pager: ( )  9   20 20 20 50 61 67 65 72 3a 20 28 20 29 20 20 39
9    AutoExit(X)   39 20 20 20 20 41 75 74 6f 45 78 69 74 28 58 29
..XP   : 2000      0d 0a 58 50 20 20 20 3a 20 32 30 30 30 20 20 20
          Mana:    20 20 20 20 20 20 20 20 20 20 4d 61 6e 61 3a 20
145   of   145     31 34 35 20 20 20 6f 66 20 20 20 31 34 35 20 20
 MKills:  00000    20 4d 4b 69 6c 6c 73 3a 20 20 30 30 30 30 30 20
   AutoLoot( )..   20 20 20 41 75 74 6f 4c 6f 6f 74 28 20 29 0d 0a
GOLD : 10,000      47 4f 4c 44 20 3a 20 31 30 2c 30 30 30 20 20 20
        Move: 11   20 20 20 20 20 20 20 20 4d 6f 76 65 3a 20 31 31
0   of   110   M   30 20 20 20 6f 66 20 20 20 31 31 30 20 20 20 4d
deaths: 00000      64 65 61 74 68 73 3a 20 30 30 30 30 30 20 20 20
 AutoSac ( )..Yo   20 41 75 74 6f 53 61 63 20 28 20 29 0d 0a 59 6f
u feel fine...La   75 20 66 65 65 6c 20 66 69 6e 65 2e 0d 0a 4c 61
nguages: common    6e 67 75 61 67 65 73 3a 20 63 6f 6d 6d 6f 6e 20
elvish dwarven p   65 6c 76 69 73 68 20 64 77 61 72 76 65 6e 20 70
ixie ogre orcish   69 78 69 65 20 6f 67 72 65 20 6f 72 63 69 73 68
 trollese rodent   20 74 72 6f 6c 6c 65 73 65 20 72 6f 64 65 6e 74

Incoming packet: 41 (380 bytes)

 insectoid mamma   20 69 6e 73 65 63 74 6f 69 64 20 6d 61 6d 6d 61
l reptile dragon   6c 20 72 65 70 74 69 6c 65 20 64 72 61 67 6f 6e
 spiritual magic   20 73 70 69 72 69 74 75 61 6c 20 6d 61 67 69 63
al goblin god an   61 6c 20 67 6f 62 6c 69 6e 20 67 6f 64 20 61 6e
cient halfling c   63 69 65 6e 74 20 68 61 6c 66 6c 69 6e 67 20 63
lan gith gnome .   6c 61 6e 20 67 69 74 68 20 67 6e 6f 6d 65 20 0d
.---------------   0a 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d
----------------   2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d
----------------   2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d
----------------   2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d
-------------..I   2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 2d 0d 0a 49
MMORTAL DATA:  W   4d 4d 4f 52 54 41 4c 20 44 41 54 41 3a 20 20 57
izinvis [ ]  Wiz   69 7a 69 6e 76 69 73 20 5b 20 5d 20 20 57 69 7a
level (65)..Bamf   6c 65 76 65 6c 20 28 36 35 29 0d 0a 42 61 6d 66
in:  Admin appea   69 6e 3a 20 20 41 64 6d 69 6e 20 61 70 70 65 61
rs in a swirling   72 73 20 69 6e 20 61 20 73 77 69 72 6c 69 6e 67
 mist...Bamfout:   20 6d 69 73 74 2e 0d 0a 42 61 6d 66 6f 75 74 3a
 Admin leaves in   20 41 64 6d 69 6e 20 6c 65 61 76 65 73 20 69 6e
 a swirling mist   20 61 20 73 77 69 72 6c 69 6e 67 20 6d 69 73 74
........[0m.[0;3   2e 0d 0a 0d 0a 0d 0a 1b 5b 30 6d 1b 5b 30 3b 33
7m<.[1;33m24hp .   37 6d 3c 1b 5b 31 3b 33 33 6d 32 34 68 70 20 1b
[1;36m145m .[1;3   5b 31 3b 33 36 6d 31 34 35 6d 20 1b 5b 31 3b 33
2m110mv.[0;37m>    32 6d 31 31 30 6d 76 1b 5b 30 3b 33 37 6d 3e 20
<#1200> .[0m       3c 23 31 32 30 30 3e 20 1b 5b 30 6d

The first part in bold seems to show a whole lot of colour changes, and the second part in bold shows the names of the languages. However the colour changes are in the wrong place.

Nick Gammon Australia Forum Administrator Tue 20 May 2008 10:25 PM #5

As far as I can see from the code the difference is that set_pager_color does a "write_to_pager" however the actual writing of languages does a "send_to_pager".

The difference is that send_to_pager checks if the pager flag is on or not, and if not, writes directly to the player, whereas the write_to_pager batches the message up. This accounts for why things are out of sequence.

I suggest that, unless there is a better idea, you change set_pager_color to do send_to_pager for consistency.

Unless, Samson has a better idea. ;)

Nick Gammon Australia Forum Administrator Tue 20 May 2008 10:27 PM #6

Please mention on the cross-posting my evaluation of the possible solution.

Whisperedecho USA Tue 20 May 2008 10:33 PM #7

Ok, cross-posted it.

Thank you very much for your help again Nick! :-)

Whisperedecho USA Tue 20 May 2008 10:45 PM #8

I can't seem to get this to work. :-(

How exactly do I modify the code so that I change set_pager_color to do send_to_pager?

Every time I try, I get compiler errors of invalid conversions from int to const char*.

Nick Gammon Australia Forum Administrator Tue 20 May 2008 10:48 PM #9

I always prefer it when you:

Post your amended code
Post the error message

These free-form descriptions force us to reproduce the error ourselves by guessing what you have done.

Whisperedecho USA Tue 20 May 2008 10:51 PM #10

This is the code that I edited:


send_to_pager( "Languages: ", ch );
   for( iLang = 0; lang_array[iLang] != LANG_UNKNOWN; iLang++ )
      if( knows_language( ch, lang_array[iLang], ch ) || ( IS_NPC( ch ) && ch->speaks == 0 ) )
      {
         if( lang_array[iLang] & ch->speaking || ( IS_NPC( ch ) && !ch->speaking ) )
            send_to_pager( AT_ORANGE, ch );
         send_to_pager( lang_names[iLang], ch );
         send_to_pager( " ", ch );
         send_to_pager( AT_SCORE, ch );
      }
   send_to_pager( "\r\n", ch );

And these are the compiler errors I am getting:


mike@valdor-server:~/smaugfuss/src$ make
make -s smaug
  Compiling o/player.o....
player.c: In function ‘void do_score(CHAR_DATA*, char*)’:
player.c:457: error: invalid conversion from ‘int’ to ‘const char*’
player.c:457: error:   initializing argument 1 of ‘void send_to_pager(const char*, CHAR_DATA*)’
make[1]: *** [o/player.o] Error 1
make: *** [all] Error 2

I know I'm doing this wrong and I feel like an idiot lol because it seems like it should be an easy solution.

Nick Gammon Australia Forum Administrator Tue 20 May 2008 11:04 PM #11

Hmm, that was why I wanted to see it. I was really suggesting fixing the bug - if it is a bug - in set_pager_color.

But let's assume we do it your way. If you look at the code for set_pager_color you see this:


void set_pager_color( short AType, CHAR_DATA * ch )
{
   if( !ch || !ch->desc )
      return;

   if( IS_NPC( ch ) )
      return;

   write_to_pager( ch->desc, color_str( AType, ch ), 0 );

The colour code (AT_ORANGE in your case) is a short, not a string, where as you are sending strings to send_to_pager, right?

The colour needs to be looked up. One way of doing it would be this:


   send_to_pager( "&CLanguages&D:  ", ch );
   for( iLang = 0; lang_array[iLang] != LANG_UNKNOWN; iLang++ )
      if( knows_language( ch, lang_array[iLang], ch ) || ( IS_NPC( ch ) && ch->speaks == 0 ) )
      {
         if( lang_array[iLang] & ch->speaking || ( IS_NPC( ch ) && !ch->speaking ) )
            send_to_pager( color_str( AT_ORANGE, ch ), ch );
         send_to_pager( lang_names[iLang], ch );
         send_to_pager( " ", ch );
         send_to_pager( color_str( AT_SCORE, ch ), ch );
      }
   send_to_pager( "\r\n", ch );

That compiles, and shows the language in the correct colour. However I found it did not show "Languages:" in colour, so that shows you are fixing one place and not the general problem.

Whisperedecho USA Tue 20 May 2008 11:06 PM #12

Ok thanks. So basically it would just be easier to wait until the bug is fixed. :-P

I could always just set it so that the pager cannot be disabled by users and that way I wouldn't run into the color problem.

Nick Gammon Australia Forum Administrator Tue 20 May 2008 11:12 PM #13

Now I'm not sure if my last post was 100% correct. Your original post had you showing the word "Languages:" in cyan which was the colour the languages were in anyway. :)

Anyway, my suggested fix to set_pager_color is as follows (line in bold). I'm not sure of the ramifications, perhaps the SmaugFUSS people can comment.


void set_pager_color( short AType, CHAR_DATA * ch )
{
   if( !ch || !ch->desc )
      return;

   if( IS_NPC( ch ) )
      return;

   send_to_pager(color_str( AType, ch ), ch );
   if( !ch->desc )
   {
      bug( "set_pager_color: NULL descriptor after WTP! CH: %s", ch->name ? ch->name : "Unknown?!?" );
      return;
   }
   ch->desc->pagecolor = ch->colors[AType];
}

With that there your original code (first post) seems to work OK. It is a bit easier to see for me at least if you change the languages line to read:


   send_to_pager( "&RLanguages&D: ", ch );

Whisperedecho USA Tue 20 May 2008 11:16 PM #14

Ok. I had actually changed the color for the score dialog to grey so it stood out for me lol. I forgot that the default color with no change was light blue.

I will cross-post it over and see what they think. Thanks.

Samson USA Tue 20 May 2008 11:57 PM #15

As far as I can see the change to set_pager_color should work fine and is probably correct usage since it will cause it to check the pager flag on the player now.

Whisperedecho USA Wed 21 May 2008 12:11 AM #16

Thank you so much for your help Nick. I changed the code over and it works perfectly now!