Compiling SmaugFUSS 1.9 Error Ubuntu

I am trying to compile SmaugFUSS 1.9 off of Ubuntu. I have installed g++ and gcc along with the "essential-build" package. I am getting the following errors when trying to compile:

mike@valdor-server:~/smaugfuss/src$ sudo make
make -s smaug
Compiling o/act_comm.o....
cc1plus: warnings being treated as errors
act_comm.c: In function ‘char* drunk_speech(const char*, CHAR_DATA*)’:
act_comm.c:209: warning: deprecated conversion from string constant to ‘char*’
act_comm.c: In function ‘void talk_channel(CHAR_DATA*, char*, int, const char*)’:
act_comm.c:403: warning: deprecated conversion from string constant to ‘char*’
act_comm.c:413: warning: deprecated conversion from string constant to ‘char*’
act_comm.c: In function ‘void do_say(CHAR_DATA*, char*)’:
act_comm.c:870: warning: deprecated conversion from string constant to ‘char*’
act_comm.c:900: warning: deprecated conversion from string constant to ‘char*’
act_comm.c: In function ‘void do_whisper(CHAR_DATA*, char*)’:
act_comm.c:996: warning: deprecated conversion from string constant to ‘char*’
act_comm.c: In function ‘void do_tell(CHAR_DATA*, char*)’:
act_comm.c:1166: warning: deprecated conversion from string constant to ‘char*’
act_comm.c: In function ‘void do_reply(CHAR_DATA*, char*)’:
act_comm.c:1323: warning: deprecated conversion from string constant to ‘char*’
act_comm.c:1329: warning: deprecated conversion from string constant to ‘char*’
act_comm.c: In function ‘void do_retell(CHAR_DATA*, char*)’:
act_comm.c:1422: warning: deprecated conversion from string constant to ‘char*’
act_comm.c: In function ‘void do_repeat(CHAR_DATA*, char*)’:
act_comm.c:1573: warning: deprecated conversion from string constant to ‘char*’
act_comm.c: In function ‘void do_emote(CHAR_DATA*, char*)’:
act_comm.c:1658: warning: deprecated conversion from string constant to ‘char*’
act_comm.c: In function ‘void do_bug(CHAR_DATA*, char*)’:
act_comm.c:1703: warning: deprecated conversion from string constant to ‘char*’
act_comm.c: In function ‘void do_idea(CHAR_DATA*, char*)’:
act_comm.c:1724: warning: deprecated conversion from string constant to ‘char*’
act_comm.c: In function ‘void do_typo(CHAR_DATA*, char*)’:
act_comm.c:1750: warning: deprecated conversion from string constant to ‘char*’
act_comm.c:1754: warning: deprecated conversion from string constant to ‘char*’
act_comm.c: In function ‘void do_quit(CHAR_DATA*, char*)’:
act_comm.c:1816: warning: deprecated conversion from string constant to ‘char*’
act_comm.c:1822: warning: deprecated conversion from string constant to ‘char*’
act_comm.c: In function ‘void do_group(CHAR_DATA*, char*)’:
act_comm.c:2286: warning: deprecated conversion from string constant to ‘char*’
act_comm.c: In function ‘void do_split(CHAR_DATA*, char*)’:
act_comm.c:2555: warning: deprecated conversion from string constant to ‘char*’
act_comm.c: In function ‘void do_gtell(CHAR_DATA*, char*)’:
act_comm.c:2616: warning: deprecated conversion from string constant to ‘char*’
act_comm.c:2618: warning: deprecated conversion from string constant to ‘char*’
act_comm.c:2621: warning: deprecated conversion from string constant to ‘char*’
act_comm.c: At global scope:
act_comm.c:2775: warning: deprecated conversion from string constant to ‘char*’
act_comm.c:2775: warning: deprecated conversion from string
make[1]: *** [o/act_comm.o] Error 1
make: *** [all] Error 2

I cut some errors out because of the 6000 char limit.

The relevant question really is, "what are the first errors"? The later ones really follow on from missing xxx.h files, usually.

If you do this, you can see all the errors:



I initially found a heap of errors, from not having the include files installed. Using the Synaptic Package Manager to install the "g++" package seemed to fix that.

However then I had less errors, but ones that started with missing zlib.h. I used the package manager to install "zlib1g-dev" package (zlib being the compression library used for MCCP).

I also would not use sudo, you don't need to compile as root, and in fact I think that would be dangerous.

After installing g++ and zlib1g-dev packages, I saw this:



This was with Ubuntu 7.04, but the same should apply to other versions.

Thanks for your suggestions Nick.

I already have the zlib1g-dev package installed along with g++. I am still encountering the same problems. I'd post all the error code but then I run into the 6000 character limit.

First errors look like this:

make -s smaug
Compiling o/act_comm.o....
cc1plus: warnings being treated as errors
act_comm.c: In function ‘char* drunk_speech(const char*, CHAR_DATA*)’:
act_comm.c:209: warning: deprecated conversion from string constant to ‘char*’
act_comm.c: In function ‘void talk_channel(CHAR_DATA*, char*, int, const char*)’:
act_comm.c:403: warning: deprecated conversion from string constant to ‘char*’
act_comm.c:413: warning: deprecated conversion from string constant to ‘char*’
act_comm.c:418: warning: deprecated conversion from string constant to ‘char*’
act_comm.c:423: warning: deprecated conversion from string constant to ‘char*’
act_comm.c:428: warning: deprecated conversion from string constant to ‘char*’
act_comm.c:444: warning: deprecated conversion from string constant to ‘char*’
act_comm.c: In function ‘void do_say(CHAR_DATA*, char*)’:
act_comm.c:870: warning: deprecated conversion from string constant to ‘char*’
act_comm.c:900: warning: deprecated conversion from string constant to ‘char*’
act_comm.c: In function ‘void do_whisper(CHAR_DATA*, char*)’:
act_comm.c:996: warning: deprecated conversion from string constant to ‘char*’
act_comm.c:1002: warning: deprecated conversion from string constant to ‘char*’
act_comm.c:1039: warning: deprecated conversion from string constant to ‘char*’
act_comm.c: In function ‘void do_tell(CHAR_DATA*, char*)’:
act_comm.c:1166: warning: deprecated conversion from string constant to ‘char*’
act_comm.c:1172: warning: deprecated conversion from string constant to ‘char*’
act_comm.c:1232: warning: deprecated conversion from string constant to ‘char*’
act_comm.c: In function ‘void do_reply(CHAR_DATA*, char*)’:
act_comm.c:1323: warning: deprecated conversion from string constant to ‘char*’
act_comm.c:1329: warning: deprecated conversion from string constant to ‘char*’
act_comm.c:1362: warning: deprecated conversion from string constant to ‘char*’
act_comm.c: In function ‘void do_retell(CHAR_DATA*, char*)’:

What version of gcc do you have? Type: gcc --version



I have 4.1.2.

Notice you are getting warnings, not errors so far. Did the make complete OK?

They look like valid warnings - as the function is returning "", which is a constant, but the function is declared as returning char * (not const char *).

However I doubt it is a big deal.

This message (from man gcc) seems to be relevant:



However I can't see -Wwrite-strings in the Makefile warnings list. You could try adding: -Wno-write-strings to the list of warnings (about line 21 in Makefile).

I have 4.2.3

I will try the other suggestion you mentioned.

The make does not complete Ok. It ends with a make error.

make[1]: *** [o/act_comm.o] Error 1
make: *** [all] Error 2

If you have -Werror in the warnings list, it treats all warnings as errors. You could try as a temporary measure to remove that part, so at least it will compile if you only get warnings.

Removed the all errors flag like you said and it seems to have compiled ok. It gave a TON of those errors though for every file. I'll check to see if it runs now.

Yep, it runs so it did compile alright.

I would try to suppress the warnings, so next time you compile you will see genuine messages without having to wade through all the warnings. See if the other flag ( -Wno-write-strings ) does that for you. If not, maybe see if you can find which warning flag will do it.

Yep, that's what I did. No more warnings! :-D

Thank you VERY much for your help Nick.

As we've mentioned several times before on the FUSS forums, this set of warnings is happening because GCC 4.2+ has enforced more strict usage of const char* and other string constants. Usually when they begin belching warnings about it in one version, they plan to make it a real error in a future release. So in the long run finding a way to fix it is pretty important. I more or less did so with AFKMud but it's a long and ultimately very boring task with not much reward to it in the end. Since AFKMud is C++ I just turned as much as I could into std::string. Not likely the best choice, but it works.

What would be nice is a fast easy way to fix the problem, other than short-circuiting the warning for now since GNU has a tendency to make that impossible later on.

Well they acknowledge the warning is a nuisance, and I think fixing it will be a long and tedious task. Basically you need to find functions that return char * and change it to const char *, which will probably break heaps of other things.

I started doing a conversion to see how it would go, but as I expected, as soon as you change one thing, it affects another.

There are quite a few functions (PACKET_FUN is an example of something that is used to define a lot of them) that are defined as taking a char * argument, but are being fed constants.

To do it properly, you need to find every function that is fed a constant, and change its definition to only accept constants, or, cast the constant, which is not a great idea. eg.



Then you find that if this function passes its arguments to another function (these arguments now being variables) but the other function also expects char * and not const char *, then the new function needs to be changed as well.

Then somewhere along the way you find that a function passes both constants and variables, which starts making you tear your hair out.

With luck they won't enforce that as an error for a long time yet, I think it would cause too much angst amongst the general programming community.