I'm currently installing a code for player installed cybernetics...when it was a command it worked fine.. now it is crashing when i turned it into a skill and added a the timer. I marked where it is crashing in the code with a ---->
chance = IS_NPC(ch) ? ch->top_level : (int) (ch->pcdata->learned[gsn_surgery]);
if ( number_percent( ) < chance )
{
send_to_char( "&GYou begin the long process of installing a cybernetic part.\n\r", ch);
act( AT_PLAIN, "$n takes $s scalpel and begins to preform the surgery.", ch, NULL, argument , TO_ROOM );
add_timer ( ch , TIMER_DO_FUN , 1 , do_installcybernetic , 1 );
ch->dest_buf = str_dup(arg1);
return;
}
send_to_char("&RYou can't figure out how to preform surgery.\n\r",ch);
learn_from_failure( ch, gsn_surgery );
return;
case 1:
if ( !ch->dest_buf )
return;
strcpy(arg1, ch->dest_buf);
DISPOSE( ch->dest_buf);
break;
case SUB_TIMER_DO_ABORT:
DISPOSE( ch->dest_buf );
ch->substate = SUB_NONE;
send_to_char("&RYou are interupted and fail to finish your work.\n\r", ch);
return;
}
ch->substate = SUB_NONE;
if ( ms_find_obj(ch) )
return;
obj = get_obj_carry( ch, arg1 );
chance = IS_NPC(ch) ? ch->top_level : (int) (ch->pcdata->learned[gsn_surgery]) ;
if ( number_percent( ) < chance )
{
send_to_char( "You realize that you installed the cybernetic part upside down and crossed some wires.", ch);
learn_from_failure( ch, gsn_surgery );
separate_obj( obj );
obj_from_char( obj );
extract_obj( obj );
return;
}
if (obj->item_type == ITEM_COMMCYBER)
{
----> if (!IS_SET(victim->pcdata->cyber, CYBER_COMM))
{
send_to_char( "&RThey seem to already have that cybernetic part installed.\n\r", ch);
return;
}
checkcyber = TRUE;
separate_obj( obj );
obj_from_char( obj );
extract_obj( obj );
SET_BIT (victim->pcdata->cyber, CYBER_COMM );
}
#0 0x08161db1 in do_installcybernetic (ch=0x851e448, argument=0x81880dc "")
at medical.c:168
#1 0x080b60ff in violence_update () at fight.c:261
#2 0x08125ddc in update_handler () at update.c:2301
#3 0x0809d105 in game_loop () at comm.c:576
#4 0x0809c578 in main (argc=7, argv=0xbfffde84) at comm.c:241
Where does the 'victim' pointer come from? It looks like you never set it, but you'll need to do that if you want this to work -- you can't dereference victim without setting it first. Also make sure as Zeno pointed out that you don't let it consider NPCs otherwise it will crash because they have no pcdata member.
Bleh. You do understand how skill timers work in stock Smaug, right? What it does is call the function, run through until it reaches the add_timer, then when the timer expires, it calls the function again.
Now, the way it keeps from repeating the same thing over and over again is by changing the char's substate to a different value. Then, it calls a switch statement based on substate to see what it should do.
In your default case, you have the checks to allocate the victim and the cybernetic part itself. You also set the first argument to a pointer on the ch (dest_buf), to be stored for later use.
Now, when the timer is called again, it is calling the function with no argument. Since the char's substate is 1, the first thing it sees is to set the new arg1 to the char's dest_buf. This is the argument it used to find the original object, so now the cybernetic part you're installing is defined.
All well and good.
However, arg2 (the victim's name) was NOT stored in the timer. Since the timer executes your function simply as installcybernetic, rather than something like installcybernetic eye simon, therefore there is no pointer allocated to the victim.
In short, what you'll need to do is assign the victim's name (or char_data) to a pointer on the installer, such as ch->installing. (NOT pcdata->installing, as you seem to have this useable for NPCs). Then, you'll need to save and reload this much as you've done for the obj (dest_buf/arg1), then perform another get_char_room on the vict to make sure he hasn't wandered off/been killed/e.t.c, to prevent another crash.
yeah i figured it out....Like i said cause i started working before i actually woke up LOL. And it works now WOO HOO thanx for the help guys... It is always something stupid i swear