Critical Hit

Alright, I downloaded Josh Jenk's critical strike snippet from kyndig, it works fine... except that it just says theres a critical strike and doesn't do any damage at all.
Help on how to add the damage would be greatly appreciated, thanks. Heres the code.

in fight.c
/*
* Critical Hit Snippet
* By Josh Jenks [ Haelyn ]
*/
if ( diceroll == 19 )
{
act( AT_FIRE, "You critically hit $N!", ch, NULL, victim, TO_CHAR );
act( AT_FIRE, "$n critically hits you!", ch, NULL, victim, TO_VICT );
act( AT_FIRE, "$n critically hits $N!", ch, NULL, victim, TO_NOTVICT );
dam = dam*2;
}

Thanks Again,

Rayze

Where exactly in fight.c is this located? Posting the 5 lines or so above your added snippet should help us find where you're at. It's likely that your code is simply in the wrong place in the function. Too 'high' would have it doubling 0, too 'low' would have it doubling damage after it was already delt.

/*
* Hit.
* Calc damage.
*/
/*
* Hit.
* Calc damage.
*/

if ( !wield ) /* bare hand dice formula fixed by Thoric */
dam = number_range( ch->barenumdie, ch->baresizedie * ch->barenumdie );
else
dam = number_range( wield->value[1], wield->value[2] );


Right after that.

Rayze

I used the same snippet from the same site, put it in the same place in fight.c, but i get this error when i recompile it. Can anyone help me out?

fight.c: In function 'one_hit" :
fight.c 4265: parse error at end of input
make[1]: *** [o/fight.o] Error 1
make: *** [all] Error 2

Did he mess up something or have I somehow messed up.
I'm compiling with Cygwin in Windows XP

Help would be mucho appreciated.

Ok I'm an idiot I had an obvious typo jammed in there that I didn't noticed but it's installed now. However I have the same problem with it not doing any damage at all.

I tried changing the line dam = dam*2;
To dam = 2 * dam;

Because I think that is the right command, however it still doesn't work.

For a start, all these are the same:

dam = dam * 2;
dam = 2 * dam;
dam *= 2;


The code looks OK, however maybe it got modified later? For instance, maybe this changed it back ...



I would put in some displays to see what is happening. eg.

printf ("At point 1 dam = %i\n", dam);

...

printf ("At point 2 dam = %i\n", dam);


Then see whether the calculation was made, and if so, where it was changed.

I really appreciate the help man, but I'm a coding newbie if it wasn't obvious by this point :P
Where do I put those commands you posted?
And how do the provide me the information I want?

Alright, take a look at mine and try it instead of that one, since this is the one that I use (I run SWR though).




Thats the one that I have and it works for me, so you might try it. Just a suggestion. I don't really know why he made it just 19's only, I changed it to 19-20. Good luck.

Thanks alot man, but what file did you put it in and where?

I'm going to try jamming it in fight.c where the other one went. Hope it works

*Shampoo is for sissies real men use poo*
[werd]thewerd.com "Smacking Your Mom Then Running Away"

Ok I've been testing this out for 20 minutes or so with a couple char's on my mud :Steve & Carl that I made to for this purpose, here's what I've found:

When it returns the "Steve mutilates you in the groin! or chest/head/hand" Value alone, there is no damage dealt at all, as you can see here.

<1397hp 100m 255mv>
Steve critically hits you in the chest!
The Cunning of Gravoc succors your learning.
Your slash barely scratches Steve.
The Cunning of Gravoc succors your learning.

<1397hp 100m 254mv>
Your slash scratches Steve.

However, when that message of a critical hit is sent *AND* a regular attack is landed it appears to double or triple the damage accordingly as is shown here:


<1451hp 100m 251mv>
Steve's slash barely scratches you. <-6 damage received

<1445hp 100m 249mv> <-8 damage received
Steve's slash barely scratches you.
Your slash barely scratches Steve.

<1437hp 100m 248mv>
You are thirsty.

<1442hp 100m 256mv> <-7 damage received
Steve's slash barely scratches you.

<1435hp 100m 255mv> <-20 damage received
Steve mutilates you in the groin! Attack Landed
Steve's slash scratches you. &
Critical Message
<1415hp 100m 254mv>
Steve drinks deeply from the flow of mystical water.

The occurrence of a critical hit attack occurring in the same round as a regular attack was much less frequent than a critical hit message with no attack and no damage.
I hope this clears things up a bit for anyone who is interested. I can only assume that the snippet is not rolling a 20 side die once for a critical hit but rolling a 20 side die twice, once to determine if a critical hit is made ie roll =19 and then again to see if you land a hit but I'm not sure if this roll is against the die again ie must =19 to hit, or using your thac0 and thac32. Anyways, whatever it is I have absolutely no idea how to fix it, but I hope someone out there does.

ahh that last part came out mangled here it is again


<1435hp 100m 255mv>
Steve mutilates you in the groin!
Steve's slash scratches you.

<1415hp 100m 254mv>
Steve drinks deeply from the flow of mystical water.

^
|
20 damage dealt when regular hit and critical message appear together, compared to the 5, 7 , and 8, damage of the other 3 attacks, which were consisent the ones before and after, all in the 4 - 9 damage range.