health bar not displaying right

Joeyfogas Wed 21 Mar 2018 05:47 AM #0

can someone help out and tell me why this code doesn't display right?

it is supposed to be a healthbar based on health percentage


send_to_char("[",ch);
int value;
value = ch->hit/ch->max_hit ;
for (start = 1; start <= 100; start++ )

{
if (start <= value * 100)
send_to_char("|",ch);
else
send_to_char(" ",ch);
}
send_to_char("] \r",ch);

it seems to only display blank unless I am at 100% health.

Joeyfogas Wed 21 Mar 2018 05:49 AM #1


output at 50% should resemble:
[|||||||||||||||               ]

i guess the forum didnt like all the spaces... won't let me edit it seems either

Joeyfogas Wed 21 Mar 2018 06:10 AM #2

i realize the written code was ugly so I cleaned it up.. it now reads:


send_to_char("[",ch);
int value = 100 * (ch->hit/ch->max_hit) ;
   for (start = 1; start <= 100; start++ )
     {
     if (start <= value )
       send_to_char("|",ch);
     else
       send_to_char(" ",ch);
    }
   send_to_char("]  \r",ch);

but same issue

Nick Gammon Australia Forum Administrator Wed 21 Mar 2018 06:42 AM #3

An integer only holds whole numbers, so for example if hit is 50 and max_hit is 100, then hit/max_hit will be zero (until hit is the same as max_hit).

You might want to work with floats here.

Joeyfogas Wed 21 Mar 2018 07:13 AM #4


send_to_char("[",ch);
float value = 100 * (ch->hit/ch->max_hit) ;
                          for (start = 1; start <= 100; start++ )

                                {
                          if (start <= value )
                                        send_to_char("|",ch);
                                  else
                                        send_to_char(" ",ch);
                                }
                    send_to_char("]  \r",ch);

still gives same outcome:

----------------------------------------------------------------------------
You are a level 65 Elf Adventurer from O'ran Thalore.
Your TIER rank is 0.

STR : 10 Attack: 0 Health: 300/600
[
]
AGI : 180 Defense: 412
INT : 180 M. Def: 0
LCK : 180

(disregard the obvious need for a length of output fix.. more focused on getting it working first)

Nick Gammon Australia Forum Administrator Wed 21 Mar 2018 07:38 AM #5

See this: http://www.gammon.com.au/forum/?id=12146

Making it float is too late.

Try changing 100 to 100.0

Joeyfogas Wed 21 Mar 2018 07:47 AM #6

nope :(

didn't work

Nick Gammon Australia Forum Administrator Wed 21 Mar 2018 08:27 AM #7

OK, the brackets didn't help. Try:


float value = 100.0 * ((float) ch->hit / (float) ch->max_hit) ;

Joeyfogas Wed 21 Mar 2018 08:40 AM #8

woohoo! that got it. THANK YOU!!