already omitted flag for triggered functions after omit+keep_evaluating

Posted by Fiendish on Sat 28 Nov 2015 01:40 PM — 3 posts, 13,792 views.

USA Global Moderator #0
Given the caveats noted in http://www.gammon.com.au/forum/bbshowpost.php?bbsubject_id=12533
("Providing the other trigger(s) haven't added to the output buffer..." and "My reply may not work for long lines...")

Maybe a 5th parameter could be added to trigger function calls after name,line,wildcards,styles that denotes whether the matched line has already been omitted? Or maybe a GetInfo flag that resets at the start of every triggering round and toggles if any trigger omits from output?
Amended on Sat 28 Nov 2015 02:20 PM by Fiendish
Australia Forum Administrator #1
What would you define as omitted? For example in ProcessPreviousLine.cpp line 462:


  if (!SendToAllPluginCallbacks (ON_PLUGIN_LINE_RECEIVED, strCurrentLine))
    bNoOutput = true;


That's omitted by a plugin callback (OnPluginLineReceived), not a trigger match.
Australia Forum Administrator #2
OK, I've changed the output line management thus:

https://github.com/nickgammon/mushclient/commit/e3a9650

Previously a local variable was used to detect if the line was (about to be) omitted from output. Now it is a global variable which you can test with GetInfo (124).